linux-kernel - Re: [PATCH v3 net-next 02/16] qed, qede, qedf: convert link mode from u32 to ETHTOOL_LINK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200720183442.GL1339445@lunn.ch>
Date:   Mon, 20 Jul 2020 20:34:42 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Alexander Lobakin <alobakin@...vell.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Igor Russkikh <irusskikh@...vell.com>,
        Michal Kalderon <michal.kalderon@...vell.com>,
        Ariel Elior <aelior@...vell.com>,
        Denis Bolotin <denis.bolotin@...vell.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        GR-everest-linux-l2@...vell.com,
        QLogic-Storage-Upstream@...vell.com, netdev@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 net-next 02/16] qed, qede, qedf: convert link mode
 from u32 to ETHTOOL_LINK_MODE

On Mon, Jul 20, 2020 at 09:08:01PM +0300, Alexander Lobakin wrote:
> Currently qed driver already ran out of 32 bits to store link modes,
> and this doesn't allow to add and support more speeds.
> Convert custom link mode to generic Ethtool bitmap and definitions
> (convenient Phylink shorthands are used for elegance and readability).
> This allowed us to drop all conversions/mappings between the driver
> and Ethtool.
> 
> This involves changes in qede and qedf as well, as they used definitions
> from shared "qed_if.h".
> 
> Suggested-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Alexander Lobakin <alobakin@...vell.com>
> Signed-off-by: Igor Russkikh <irusskikh@...vell.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_main.c    | 288 ++++++++++--------
>  .../net/ethernet/qlogic/qede/qede_ethtool.c   | 200 ++++--------
>  drivers/scsi/qedf/qedf_main.c                 |  78 +++--
>  include/linux/qed/qed_if.h                    |  47 +--
>  4 files changed, 268 insertions(+), 345 deletions(-)

Nice diffstat.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew