linux-kernel - Re: [net-next v4 PATCH 1/7] hsr: enhance netlink socket interface to support PRP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1675af9-f057-0b7b-c245-e15ead602bbc@infradead.org>
Date:   Mon, 20 Jul 2020 11:37:28 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Murali Karicheri <m-karicheri2@...com>, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        nsekhar@...com, grygorii.strashko@...com, vinicius.gomes@...el.com
Subject: Re: [net-next v4 PATCH 1/7] hsr: enhance netlink socket interface to
 support PRP

On 7/20/20 9:57 AM, Murali Karicheri wrote:
> diff --git a/net/hsr/Kconfig b/net/hsr/Kconfig
> index 8095b034e76e..e2e396870230 100644
> --- a/net/hsr/Kconfig
> +++ b/net/hsr/Kconfig
> @@ -4,24 +4,35 @@
>  #
>  
>  config HSR
> -	tristate "High-availability Seamless Redundancy (HSR)"
> -	help
> +	tristate "High-availability Seamless Redundancy (HSR & PRP)"
> +	---help---

Just use:
	help

The use of "---help---" has been discontinued.

> +	  This enables IEC 62439 defined High-availability Seamless
> +	  Redundancy (HSR) and Parallel Redundancy Protocol (PRP).
> +
>  	  If you say Y here, then your Linux box will be able to act as a
> -	  DANH ("Doubly attached node implementing HSR"). For this to work,
> -	  your Linux box needs (at least) two physical Ethernet interfaces,
> -	  and it must be connected as a node in a ring network together with
> -	  other HSR capable nodes.
> +	  DANH ("Doubly attached node implementing HSR") or DANP ("Doubly
> +	  attached node implementing PRP"). For this to work, your Linux box
> +	  needs (at least) two physical Ethernet interfaces.
> +
> +	  For DANH, it must be connected as a node in a ring network together
> +	  with other HSR capable nodes. All Ethernet frames sent over the hsr

	                                                                  HSR

> +	  device will be sent in both directions on the ring (over both slave
> +	  ports), giving a redundant, instant fail-over network. Each HSR node
> +	  in the ring acts like a bridge for HSR frames, but filters frames
> +	  that have been forwarded earlier.
>  
> -	  All Ethernet frames sent over the hsr device will be sent in both
> -	  directions on the ring (over both slave ports), giving a redundant,
> -	  instant fail-over network. Each HSR node in the ring acts like a
> -	  bridge for HSR frames, but filters frames that have been forwarded
> -	  earlier.
> +	  For DANP, it must be connected as a node connecting to two
> +	  separate networks over the two slave interfaces. Like HSR, Ethernet
> +	  frames sent over the prp device will be sent to both networks giving

	                       PRP

> +	  a redundant, instant fail-over network. Unlike HSR, PRP networks
> +	  can have Singly Attached Nodes (SAN) such as PC, printer, bridges
> +	  etc and will be able to communicate with DANP nodes.
>  
>  	  This code is a "best effort" to comply with the HSR standard as
>  	  described in IEC 62439-3:2010 (HSRv0) and IEC 62439-3:2012 (HSRv1),
> -	  but no compliancy tests have been made. Use iproute2 to select
> -	  the version you desire.
> +	  and PRP standard described in IEC 62439-4:2012 (PRP), but no
> +	  compliancy tests have been made. Use iproute2 to select the protocol
> +	  you would like to use.
>  
>  	  You need to perform any and all necessary tests yourself before
>  	  relying on this code in a safety critical system!

thanks.
-- 
~Randy