linux-kernel - Re: [PATCH v4 0/5] powerpc/perf: Add json file support for hv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200720193149.GA3906670@kernel.org>
Date:   Mon, 20 Jul 2020 16:31:49 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Kajol Jain <kjain@...ux.ibm.com>, ak@...ux.intel.com,
        peterz@...radead.org, mingo@...hat.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, pc@...ibm.com,
        namhyung@...nel.org, yao.jin@...ux.intel.com,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        irogers@...gle.com, maddy@...ux.ibm.com,
        ravi.bangoria@...ux.ibm.com, anju@...ux.vnet.ibm.com,
        kan.liang@...ux.intel.com, nasastry@...ibm.com
Subject: Re: [PATCH v4 0/5] powerpc/perf: Add json file support for hv_24x7
 core level events

Em Mon, Jul 20, 2020 at 09:21:33PM +0200, Jiri Olsa escreveu:
> On Mon, Jul 20, 2020 at 12:31:22PM +0530, Kajol Jain wrote:
> > Patchset enhance current runtime parameter support. It introduces new
> > fields like "PerChip" and "PerCore" similar to the field "PerPkg" which is
> > used to specify perpkg events. 
> > 
> > The "PerCore" and "PerChip" specifies whether its core or chip events.
> > Based on which we can decide which runtime parameter user want to
> > access. Now character  '?' can refers different parameter based on user
> > requirement.
> > 
> > Initially, every time we want to add new terms like chip, core, thread
> > etc, we need to create corrsponding fields in pmu_events and event
> > struct.
> > This patchset adds an enum called 'aggr_mode_class' which store all these
> > aggregation like perpkg/percore. It also adds new field 'AggregationMode'
> > to capture these terms.
> > Now, if user wants to add any new term, they just need to add it in
> > the enum defined. I try to test it with  my current setup.
> > 
> > I also need to replace PerPkg field to AggregationMode in all the
> > x86 uncore json files. It will great if Andi and team can test it
> > and let me know if they have any concerns.
> > 
> > Changelog:
> > v3 -> v4:
> > - Include pmu-events.h header file in jevents.c and remove
> >   redecalaration of enum aggr_mode_class as Suggested by Jiri.
> > - Add Acked-by tag.
> 
> looks good to me, but still missing reaction from people maintaining
> intel's jsons

Yeah, since this is something trying to be generic enough to describe
events from different arches, we should not double-fail into
generalizing this :-\

- Arnaldo