linux-kernel - Re: [PATCH] media: v4l2-dev/ioctl: Fix document for VIDIOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91e92ed1-5364-884d-79ab-20d64594deb2@koikeco.de>
Date:   Mon, 20 Jul 2020 16:45:26 -0300
From:   Helen Koike <helen@...keco.de>
To:     Jian-Jia Su <jjsu@...omium.org>, linux-media@...r.kernel.org
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Helen Koike <helen.koike@...labora.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: v4l2-dev/ioctl: Fix document for VIDIOC_QUERYCAP

Hi,

On 7/20/20 6:29 AM, Jian-Jia Su wrote:
> V4L2_CAP_VIDEO_M2M is documented as 0x00004000
> V4L2_CAP_VIDEO_M2M_MPLANE is documented as 0x00008000
> This is different from the definition in include/uapi/linux/videodev2.h
> 

Nice catch, they are swapped in the docs indeed.

>From videodev2.h:

/* Is a video mem-to-mem device that supports multiplanar formats */
#define V4L2_CAP_VIDEO_M2M_MPLANE	0x00004000
/* Is a video mem-to-mem device */
#define V4L2_CAP_VIDEO_M2M		0x00008000

> Signed-off-by: Jian-Jia Su <jjsu@...omium.org>

Reviewed-by: Helen Koike <helen.koike@...labora.com>

Regards,
Helen

> ---
>  Documentation/userspace-api/media/v4l/vidioc-querycap.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/userspace-api/media/v4l/vidioc-querycap.rst b/Documentation/userspace-api/media/v4l/vidioc-querycap.rst
> index 666ac4d420519..90347367ef06a 100644
> --- a/Documentation/userspace-api/media/v4l/vidioc-querycap.rst
> +++ b/Documentation/userspace-api/media/v4l/vidioc-querycap.rst
> @@ -168,11 +168,11 @@ specification the ioctl returns an ``EINVAL`` error code.
>        - The device supports the :ref:`multi-planar API <planar-apis>`
>  	through the :ref:`Video Output <output>` interface.
>      * - ``V4L2_CAP_VIDEO_M2M``
> -      - 0x00004000
> +      - 0x00008000
>        - The device supports the single-planar API through the Video
>  	Memory-To-Memory interface.
>      * - ``V4L2_CAP_VIDEO_M2M_MPLANE``
> -      - 0x00008000
> +      - 0x00004000
>        - The device supports the :ref:`multi-planar API <planar-apis>`
>  	through the Video Memory-To-Memory interface.
>      * - ``V4L2_CAP_VIDEO_OVERLAY``
>