linux-kernel - Re: [PATCH V3 4/6] Add support in arm64 to store the memory information of the IMA measurement log in the kimage used for kexec.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jul 2020 03:24:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Prakhar Srivastava <prsriva@...ux.microsoft.com>,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, catalin.marinas@....com, will@...nel.org,
        mpe@...erman.id.au, benh@...nel.crashing.org, paulus@...ba.org,
        robh+dt@...nel.org, frowand.list@...il.com
Subject: Re: [PATCH V3 4/6] Add support in arm64 to store the memory
 information of the IMA measurement log in the kimage used for kexec.

Hi Prakhar,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on powerpc/next integrity/next-integrity v5.8-rc6 next-20200720]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Prakhar-Srivastava/Add-support-to-carry-forward-the-IMA-measurement-logs/20200720-232521
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> arch/arm64/kernel/machine_kexec_file.c:49:5: warning: no previous prototype for 'arch_ima_add_kexec_buffer' [-Wmissing-prototypes]
      49 | int arch_ima_add_kexec_buffer(struct kimage *image, unsigned long load_addr,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +/arch_ima_add_kexec_buffer +49 arch/arm64/kernel/machine_kexec_file.c

    40	
    41	/**
    42	 * arch_ima_add_kexec_buffer - do arch-specific steps to add the IMA buffer
    43	 *
    44	 * Architectures should use this function to pass on the IMA buffer
    45	 * information to the next kernel.
    46	 *
    47	 * Return: 0 on success, negative errno on error.
    48	 */
  > 49	int arch_ima_add_kexec_buffer(struct kimage *image, unsigned long load_addr,
    50				      size_t size)
    51	{
    52		image->arch.ima_buffer_addr = load_addr;
    53		image->arch.ima_buffer_size = size;
    54		return 0;
    55	}
    56	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (73571 bytes)