linux-kernel - Re: [v3] arm64: dts: sc7180: add nodes for idp display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <159527668913.1987609.9777678660905277260@swboyd.mtv.corp.google.com>
Date:   Mon, 20 Jul 2020 13:24:49 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     harigovi@...eaurora.org
Cc:     devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, robdclark@...il.com,
        seanpaul@...omium.org, hoegsberg@...omium.org,
        kalyan_t@...eaurora.org, nganji@...eaurora.org
Subject: Re: [v3] arm64: dts: sc7180: add nodes for idp display

Quoting harigovi@...eaurora.org (2020-06-29 06:50:09)
> On 2020-06-25 06:37, Stephen Boyd wrote:
> > Quoting Harigovindan P (2020-02-17 00:58:42)
> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts 
> >> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> >> index 388f50ad4fde..349db8fe78a5 100644
> >> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> >> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> >> @@ -232,6 +233,57 @@ vreg_bob: bob {
[...]
> >> +       ports {
> >> +               port@1 {
> >> +                       endpoint {
> >> +                               remote-endpoint = <&panel0_in>;
> >> +                               data-lanes = <0 1 2 3>;
> > 
> > Is this property needed? If it's the default assumption it would be 
> > nice
> > to omit it so that we don't have to think about it.
> > This property is needed during panel probe. If this is not mentioned 
> > here,
> mipi_dsi_attach() will fail during panel probe. In dsi_host.c, 
> dsi_host_attach()
> fails since dsi lanes are greater than msm_host lanes. msm_host lanes 
> are updated
> as part of dsi_host_parse_dt. If we dont provide data-lanes in dt, it'll 
> have default
> value and fail in dsi_host_attach().

What is the default value? It looks like dsi_host_parse_dt() says it's
using a default but I guess the default is 0 lanes? Why not make it the
normal 4 lanes?