linux-kernel - Re: [GIT PULL] VFIO fix for v5.8-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200720150138.5c13e8b9@x1.home>
Date:   Mon, 20 Jul 2020 15:01:38 -0600
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Cornelia Huck <cohuck@...hat.com>, prime.zeng@...ilicon.com
Subject: Re: [GIT PULL] VFIO fix for v5.8-rc7

On Mon, 20 Jul 2020 13:33:29 -0700
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Mon, Jul 20, 2020 at 7:34 AM Alex Williamson
> <alex.williamson@...hat.com> wrote:
> >
> > VFIO fixes for v5.8-rc7
> >
> >  - Fix race with eventfd ctx cleared outside of mutex (Zeng Tao)  
> 
> Why does this take and then re-take the lock immediately? That just
> looks insane.
> 
> I realize that this isn't likely to be a performance-critical path,
> but this is a basic source cleanliness issue. Doing silly things is
> silly, and shouldn't be done, even if they don't matter.

Yup, it's silly.  Cornelia identified the same during review and I let
it slide after some counter arguments by the submitter.  I see this got
merged, so I'll post a cleanup for v5.9.  Thanks for the input,

Alex