linux-kernel - RE: [PATCH v2 11/15] scsi: hpsa: use generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Jul 2020 22:23:09 +0000
From:   <Don.Brace@...rochip.com>
To:     <vaibhavgupta40@...il.com>, <helgaas@...nel.org>,
        <bhelgaas@...gle.com>, <bjorn@...gaas.com>,
        <vaibhav.varodek@...il.com>, <aradford@...il.com>,
        <jejb@...ux.ibm.com>, <martin.petersen@...cle.com>,
        <aacraid@...rosemi.com>, <hare@...e.com>,
        <linuxdrivers@...otech.com>, <john.garry@...wei.com>,
        <don.brace@...rosemi.com>, <james.smart@...adcom.com>,
        <dick.kennedy@...adcom.com>, <kashyap.desai@...adcom.com>,
        <sumit.saxena@...adcom.com>,
        <shivasharan.srikanteshwara@...adcom.com>,
        <sathya.prakash@...adcom.com>, <sreekanth.reddy@...adcom.com>,
        <suganath-prabu.subramani@...adcom.com>,
        <jinpu.wang@...ud.ionos.com>
CC:     <skhan@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        <linux-scsi@...r.kernel.org>, <esc.storagedev@...rosemi.com>,
        <megaraidlinux.pdl@...adcom.com>,
        <MPT-FusionLinux.pdl@...adcom.com>
Subject: RE: [PATCH v2 11/15] scsi: hpsa: use generic power management

Drivers using legacy PM have to manage PCI states and device's PM states themselves. They also need to take care of configuration registers.

With improved and powerful support of generic PM, PCI Core takes care of above mentioned, device-independent, jobs.

Change function parameter in both .suspend() and .resume() to "struct device*" type. The function body remains unchanged as it was empty.
Also, bind callbacks with "static const struct dev_pm_ops" variable.

Compile-tested only.

Signed-off-by: Vaibhav Gupta <vaibhavgupta40@...il.com>

Acked-by: Don Brace <don.brace@...rosemi.com>
Compile-tested: no compile/sparse issues found.
Tested-by: Don Brace <don.brace@...rosemi.com>
   (for hpsa driver)