linux-kernel - Re: [PATCH] firmware: ti_sci: Replace HTTP links with HTTPS ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7b6caa87-8672-b5d5-ef8d-2fd38a4b53e6@ti.com>
Date:   Mon, 20 Jul 2020 10:32:13 +0300
From:   Tero Kristo <t-kristo@...com>
To:     "Alexander A. Klimov" <grandmaster@...klimov.de>, <nm@...com>,
        <ssantosh@...nel.org>, <tglx@...utronix.de>,
        <jason@...edaemon.net>, <maz@...nel.org>, <robh+dt@...nel.org>,
        <p.zabel@...gutronix.de>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH] firmware: ti_sci: Replace HTTP links with HTTPS ones

Hi Alexander,

One comment below.

On 18/07/2020 13:55, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> 
> Deterministic algorithm:
> For each file:
>    If not .svg:
>      For each line:
>        If doesn't contain `\bxmlns\b`:
>          For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> 	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
>              If both the HTTP and HTTPS versions
>              return 200 OK and serve the same content:
>                Replace HTTP with HTTPS.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>
> ---
>   Continuing my work started at 93431e0607e5.
>   See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@...klimov.de>' v5.7..master
> 
>   If there are any URLs to be removed completely
>   or at least not (just) HTTPSified:
>   Just clearly say so and I'll *undo my change*.
>   See also: https://lkml.org/lkml/2020/6/27/64
> 
>   If there are any valid, but yet not changed URLs:
>   See: https://lkml.org/lkml/2020/6/26/837
> 
>   If you apply the patch, please let me know.
> 
> 
>   .../devicetree/bindings/interrupt-controller/ti,sci-intr.txt    | 2 +-
>   drivers/firmware/ti_sci.c                                       | 2 +-
>   drivers/firmware/ti_sci.h                                       | 2 +-
>   drivers/irqchip/irq-ti-sci-inta.c                               | 2 +-
>   drivers/irqchip/irq-ti-sci-intr.c                               | 2 +-
>   drivers/reset/reset-ti-sci.c                                    | 2 +-
>   include/linux/soc/ti/ti_sci_inta_msi.h                          | 2 +-
>   include/linux/soc/ti/ti_sci_protocol.h                          | 2 +-
>   8 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
> index 1a8718f8855d..178fca08278f 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
> @@ -55,7 +55,7 @@ Required Properties:
>   			corresponds to a range of host irqs.
>   
>   For more details on TISCI IRQ resource management refer:
> -http://downloads.ti.com/tisci/esd/latest/2_tisci_msgs/rm/rm_irq.html
> +https://downloads.ti.com/tisci/esd/latest/2_tisci_msgs/rm/rm_irq.html
>   
>   Example:
>   --------
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 4126be9e3216..53cee17d0115 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -2,7 +2,7 @@
>   /*
>    * Texas Instruments System Control Interface Protocol Driver
>    *
> - * Copyright (C) 2015-2016 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2015-2016 Texas Instruments Incorporated - https://www.ti.com/
>    *	Nishanth Menon
>    */
>   
> diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h
> index f0d068c03944..57cd04062994 100644
> --- a/drivers/firmware/ti_sci.h
> +++ b/drivers/firmware/ti_sci.h
> @@ -6,7 +6,7 @@
>    * The system works in a message response protocol
>    * See: http://processors.wiki.ti.com/index.php/TISCI for details

^^^^

You should probably replace that one as well to be https while doing the 
rest of the changes, even though the wiki is being deprecated during 
this year.

-Tero

>    *
> - * Copyright (C)  2015-2016 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C)  2015-2016 Texas Instruments Incorporated - https://www.ti.com/
>    */
>   
>   #ifndef __TI_SCI_H
> diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
> index 7e3ebf6ed2cd..85de19fe9b6e 100644
> --- a/drivers/irqchip/irq-ti-sci-inta.c
> +++ b/drivers/irqchip/irq-ti-sci-inta.c
> @@ -2,7 +2,7 @@
>   /*
>    * Texas Instruments' K3 Interrupt Aggregator irqchip driver
>    *
> - * Copyright (C) 2018-2019 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2018-2019 Texas Instruments Incorporated - https://www.ti.com/
>    *	Lokesh Vutla <lokeshvutla@...com>
>    */
>   
> diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c
> index 59d51a20bbd8..5ea148faf2ab 100644
> --- a/drivers/irqchip/irq-ti-sci-intr.c
> +++ b/drivers/irqchip/irq-ti-sci-intr.c
> @@ -2,7 +2,7 @@
>   /*
>    * Texas Instruments' K3 Interrupt Router irqchip driver
>    *
> - * Copyright (C) 2018-2019 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2018-2019 Texas Instruments Incorporated - https://www.ti.com/
>    *	Lokesh Vutla <lokeshvutla@...com>
>    */
>   
> diff --git a/drivers/reset/reset-ti-sci.c b/drivers/reset/reset-ti-sci.c
> index bf68729ab729..b799aefad547 100644
> --- a/drivers/reset/reset-ti-sci.c
> +++ b/drivers/reset/reset-ti-sci.c
> @@ -1,7 +1,7 @@
>   /*
>    * Texas Instrument's System Control Interface (TI-SCI) reset driver
>    *
> - * Copyright (C) 2015-2017 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2015-2017 Texas Instruments Incorporated - https://www.ti.com/
>    *	Andrew F. Davis <afd@...com>
>    *
>    * This program is free software; you can redistribute it and/or modify
> diff --git a/include/linux/soc/ti/ti_sci_inta_msi.h b/include/linux/soc/ti/ti_sci_inta_msi.h
> index 11fb5048f5f6..e3aa8b14612e 100644
> --- a/include/linux/soc/ti/ti_sci_inta_msi.h
> +++ b/include/linux/soc/ti/ti_sci_inta_msi.h
> @@ -2,7 +2,7 @@
>   /*
>    * Texas Instruments' K3 TI SCI INTA MSI helper
>    *
> - * Copyright (C) 2018-2019 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2018-2019 Texas Instruments Incorporated - https://www.ti.com/
>    *	Lokesh Vutla <lokeshvutla@...com>
>    */
>   
> diff --git a/include/linux/soc/ti/ti_sci_protocol.h b/include/linux/soc/ti/ti_sci_protocol.h
> index 9531ec823298..0fc452dd96d4 100644
> --- a/include/linux/soc/ti/ti_sci_protocol.h
> +++ b/include/linux/soc/ti/ti_sci_protocol.h
> @@ -2,7 +2,7 @@
>   /*
>    * Texas Instruments System Control Interface Protocol
>    *
> - * Copyright (C) 2015-2016 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2015-2016 Texas Instruments Incorporated - https://www.ti.com/
>    *	Nishanth Menon
>    */
>   
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki