linux-kernel - Re: [PATCH v3] staging: kpc2000: Replace depracated MSI APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200720083259.GE2549@kadam>
Date:   Mon, 20 Jul 2020 11:32:59 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Suraj Upadhyay <usuraj35@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: kpc2000: Replace depracated MSI APIs

On Sun, Jul 19, 2020 at 07:42:22PM +0530, Suraj Upadhyay wrote:
> Replace depracated MSI IRQ enabler and disabler
> with pci_alloc_irq_vectors and pci_free_irq_vectors respectively.
> Compile tested.
> 
> Signed-off-by: Suraj Upadhyay <usuraj35@...il.com>
> ---
> Changes:
> 	v3: Replaced the disabler for MSI IRQ too with
>             pci_free_irq_vectors.

No, this still has bugs.  Grep the file for msi and update everything
and update the comments and label names as well.

Can you just slow down a bit and fix one driver correctly before trying
to fix a bunch of drivers?

regards,
dan carpenter