linux-kernel - RE: [PATCH V1 RESEND 2/3] bindings/perf/imx-ddr: update compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB8PR04MB679528762BB39926FBCDE36EE67B0@DB8PR04MB6795.eurprd04.prod.outlook.com>
Date:   Mon, 20 Jul 2020 08:57:48 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     John Garry <john.garry@...wei.com>,
        "will@...nel.org" <will@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V1 RESEND 2/3] bindings/perf/imx-ddr: update compatible
 string


> -----Original Message-----
> From: John Garry <john.garry@...wei.com>
> Sent: 2020年7月15日 19:04
> To: Joakim Zhang <qiangqing.zhang@....com>; will@...nel.org;
> mark.rutland@....com; robh+dt@...nel.org; shawnguo@...nel.org
> Cc: dl-linux-imx <linux-imx@....com>; linux-arm-kernel@...ts.infradead.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH V1 RESEND 2/3] bindings/perf/imx-ddr: update compatible
> string
> 
> On 12/05/2020 08:31, Joakim Zhang wrote:
> > Update compatible string according to driver change.`
> >
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
> > ---
> >   Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > index 7822a806ea0a..b27a1d4fec78 100644
> > --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt
> > @@ -4,7 +4,9 @@ Required properties:
> >
> 
> Hi Joakim,
> 
> >   - compatible: should be one of:
> >   	"fsl,imx8-ddr-pmu"
> > -	"fsl,imx8m-ddr-pmu"
> > +	"fsl,imx8mq-ddr-pmu"
> > +	"fsl,imx8mm-ddr-pmu"
> 
> I noticed that some of the compat strings being added are used in imx dtsi files
> today:
> 
> john@...alhost:~/linux> git grep "fsl,imx8mm-ddr-pmu"
> arch/arm64/boot/dts/freescale/imx8mm.dtsi:  compatible =
> "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu";
> 
> Any specific reason why they are not described in the dt bindings already?
> 
> I don't follow dt so much anymore, so don't know the policies.

Hi John,

What I did is not standard, any compat string in dts file should be described in the dt bindings. I will keep in mind.

Best Regards,
Joakim Zhang
> > +	"fsl,imx8mn-ddr-pmu"
> 
> Thanks,
> John