linux-kernel - Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <636380f452ff696ab4505ad09dcea951283be06b.camel@pengutronix.de>
Date:   Mon, 20 Jul 2020 11:37:51 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Rajesh Gumasta <rgumasta@...dia.com>, ldewangan@...dia.com,
        jonathanh@...dia.com, vkoul@...nel.org, dan.j.williams@...el.com,
        thierry.reding@...il.com, dmaengine@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kyarlagadda@...dia.com, Pavan Kunapuli <pkunapuli@...dia.com>
Subject: Re: [Patch v1 2/4] dma: tegra: Adding Tegra GPC DMA controller
 driver

Hi Rajesh,

On Mon, 2020-07-20 at 12:04 +0530, Rajesh Gumasta wrote:
> +
> +       tdma->rst = devm_reset_control_get(&pdev->dev, "gpcdma");

Please use devm_reset_control_get_exclusive() directly.

> +       if (IS_ERR(tdma->rst)) {
> +               dev_err(&pdev->dev, "Missing controller reset\n");

You might want to suppress this message if the error is EPROBE_DEFER.

> +               return PTR_ERR(tdma->rst);
> +       }
> +       reset_control_reset(tdma->rst);

regards
Philipp