linux-kernel - Re: [PATCH v31 01/12] leds: multicolor: Introduce a multicolor class definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200720095409.GA13137@amd>
Date:   Mon, 20 Jul 2020 11:54:09 +0200
From:   Pavel Machek <pavel@....cz>
To:     Dan Murphy <dmurphy@...com>
Cc:     jacek.anaszewski@...il.com, robh@...nel.org, marek.behun@....cz,
        devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v31 01/12] leds: multicolor: Introduce a multicolor class
 definition

Hi!

> Introduce a multicolor class that groups colored LEDs
> within a LED node.
> 
> The multicolor class groups monochrome LEDs and allows controlling two
> aspects of the final combined color: hue and lightness. The former is
> controlled via the intensity file and the latter is controlled
> via brightness file.
> 
> Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> Signed-off-by: Dan Murphy <dmurphy@...com>

Thanks, applied and pushed out.

> +====================================
> +MultiColor LED handling under Linux
> +====================================
...
> +Multicolor Class Control
> +========================

AFAICT The first one should be "Multicolor" for consistency.

> +config LEDS_CLASS_MULTICOLOR
> +	tristate "LED MultiColor Class Support"

Here too.

Can you send a followup patch to fix it up?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)