linux-kernel - Re: [PATCH] HID: udraw-ps3: Replace HTTP links with HTTPS ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Jul 2020 12:25:08 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Bastien Nocera <hadess@...ess.net>
cc:     "Alexander A. Klimov" <grandmaster@...klimov.de>,
        benjamin.tissoires@...hat.com, mpe@...erman.id.au,
        benh@...nel.crashing.org, paulus@...ba.org,
        linux-input@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: udraw-ps3: Replace HTTP links with HTTPS ones

On Sat, 18 Jul 2020, Bastien Nocera wrote:

> > Rationale:
> > Reduces attack surface on kernel devs opening the links for MITM
> > as HTTPS traffic is much harder to manipulate.
> > 
> > Deterministic algorithm:
> > For each file:
> >   If not .svg:
> >     For each line:
> >       If doesn't contain `\bxmlns\b`:
> >         For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> > 	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> >             If both the HTTP and HTTPS versions
> >             return 200 OK and serve the same content:
> >               Replace HTTP with HTTPS.
> > 
> > Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>
> 
> Looks good!
> 
> Acked-by: Bastien Nocera <hadess@...ess.net>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs