linux-kernel - RE: [PATCH v5] rtc: rtc-ds1374: wdt: Use watchdog core for watchdog part

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Jul 2020 10:44:41 +0000
From:   Johnson CH Chen (陳昭勳) 
        <JohnsonCH.Chen@...a.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
CC:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: RE: [PATCH v5] rtc: rtc-ds1374: wdt: Use watchdog core for watchdog
 part

Hi Alexandre,

> > v4->v5:
> > - Fix reported build error by replacing RTC_DRV_DS1374_WDT with
> > WATCHDOG_CORE
> >
> 
> This is not the correct solution as this will remove the alarm functionality for
> anyone enabling WATCHDOG. I already submitted a proper fix.
> 

It's an appropriate and better solution. Thanks!

RTC_DRV_DS1374_WDT still should select WATCHDOG_CORE to avoid build error if WATCHDOG_CORE is set to "m", and it should be depended on RTC_DRV_DS1374 and WATCHDOG.

> > v3->v4:
> > - Fix coding styles
> > - Remove dev_info() in ds1374_wdt_settimeout()
> > - Fix missing error check
> >
> 
> --

Best regards,
Johnson