linux-kernel - Re: [PATCH] ath11k: Fix memory leak in ath11k_qmi_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9379ef46-5931-5542-c424-916bb8476a92@web.de>
Date:   Mon, 20 Jul 2020 13:07:53 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wang Yufen <wangyufen@...wei.com>, brcm80211-dev-list@...ress.com,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Franky Lin <franky.lin@...adcom.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        Wright Feng <wright.feng@...ress.com>
Subject: Re: [PATCH] ath11k: Fix memory leak in ath11k_qmi_init_service()

> When qmi_add_lookup fail, we should destroy the workqueue

Can the following wording variant be nicer for the change description?

   Destroy the work queue object in an if branch
   after a call of the function “qmi_add_lookup” failed.

Regards,
Markus