linux-kernel - Re: [PATCH] ipmi: Remove duplicate code in __ipmi_bmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <2084072d-e16c-d47c-6eed-f47e8f149c44@web.de>
Date:   Mon, 20 Jul 2020 14:07:50 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Corey Minyard <cminyard@...sta.com>,
        Jing Xiangfeng <jingxiangfeng@...wei.com>,
        openipmi-developer@...ts.sourceforge.net
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>, Corey Minyard <minyard@....org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] ipmi: Remove duplicate code in __ipmi_bmc_register()

> > __ipmi_bmc_register() jumps to the label 'out_free_my_dev_name' in an
> > error path. So we can remove duplicate code in the if (rv).
>
> Looks correct, queued for next release.

1. Can an imperative wording be preferred for the change description?

2. Will the tag “Fixes” become helpful for the commit message?

3. Did you avoid a typo in the patch subject?

Regards,
Markus