linux-kernel - [PATCH] clk: ti: clkctrl: add the missed kfree() for _ti_omap4_clkctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Jul 2020 20:23:43 +0800
From:   Jing Xiangfeng <jingxiangfeng@...wei.com>
To:     <t-kristo@...com>, <mturquette@...libre.com>, <sboyd@...nel.org>,
        <tony@...mide.com>, <robh@...nel.org>
CC:     <linux-omap@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <jingxiangfeng@...wei.com>
Subject: [PATCH] clk: ti: clkctrl: add the missed kfree() for _ti_omap4_clkctrl_setup()

_ti_omap4_clkctrl_setup() misses to call kfree() in an error path. Add
the missed function call to fix it.

Fixes: 6c3090520554 ("clk: ti: clkctrl: Fix hidden dependency to node name")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>
---
 drivers/clk/ti/clkctrl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/ti/clkctrl.c b/drivers/clk/ti/clkctrl.c
index 864c484bde1b..868e50132c21 100644
--- a/drivers/clk/ti/clkctrl.c
+++ b/drivers/clk/ti/clkctrl.c
@@ -655,8 +655,10 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)
 		}
 
 		hw = kzalloc(sizeof(*hw), GFP_KERNEL);
-		if (!hw)
+		if (!hw) {
+			kfree(clkctrl_name);
 			return;
+		}
 
 		hw->enable_reg.ptr = provider->base + reg_data->offset;
 
-- 
2.17.1