linux-kernel - R: [PATCH v10 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Jul 2020 14:25:18 +0200
From:   <ansuelsmth@...il.com>
To:     "'Vinod Koul'" <vkoul@...nel.org>
Cc:     "'Andy Gross'" <agross@...eaurora.org>,
        "'Jonathan McDowell'" <noodles@...th.li>,
        "'Andy Gross'" <agross@...nel.org>,
        "'Bjorn Andersson'" <bjorn.andersson@...aro.org>,
        "'Kishon Vijay Abraham I'" <kishon@...com>,
        "'Rob Herring'" <robh+dt@...nel.org>,
        "'Mark Rutland'" <mark.rutland@....com>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>
Subject: R: [PATCH v10 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver



> -----Messaggio originale-----
> Da: Vinod Koul <vkoul@...nel.org>
> Inviato: lunedì 20 luglio 2020 08:26
> A: Ansuel Smith <ansuelsmth@...il.com>
> Cc: Andy Gross <agross@...eaurora.org>; Jonathan McDowell
> <noodles@...th.li>; Andy Gross <agross@...nel.org>; Bjorn Andersson
> <bjorn.andersson@...aro.org>; Kishon Vijay Abraham I <kishon@...com>;
> Rob Herring <robh+dt@...nel.org>; Mark Rutland
> <mark.rutland@....com>; linux-arm-msm@...r.kernel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org
> Oggetto: Re: [PATCH v10 1/2] phy: qualcomm: add qcom ipq806x dwc usb
> phy driver
> 
> On 17-07-20, 15:16, Ansuel Smith wrote:
> > This has lost in the original push for the dwc3 qcom driver.
> > This is needed for ipq806x SoC as without this the usb ports
> > doesn't work at all.
> 
> Applied both, thanks
> 
> My script found below errors with W=1, can you please send fixes for
> these
> 

Since you applied them should I send a new patch or a v11 of 
this patchset?

> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function
> parameter or member 'phy_dwc3' not described in
> 'usb_phy_write_readback'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function
> parameter or member 'offset' not described in 'usb_phy_write_readback'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function
> parameter or member 'mask' not described in 'usb_phy_write_readback'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:140: warning: Function
> parameter or member 'val' not described in 'usb_phy_write_readback'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:182: warning: Function
> parameter or member 'phy_dwc3' not described in 'usb_ss_write_phycreg'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:182: warning: Function
> parameter or member 'addr' not described in 'usb_ss_write_phycreg'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:182: warning: Function
> parameter or member 'val' not described in 'usb_ss_write_phycreg'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:219: warning: Function
> parameter or member 'phy_dwc3' not described in 'usb_ss_read_phycreg'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:219: warning: Function
> parameter or member 'addr' not described in 'usb_ss_read_phycreg'
> drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c:219: warning: Function
> parameter or member 'val' not described in 'usb_ss_read_phycreg'
> 
> --
> ~Vinod