linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd74c280-80e2-910b-0770-72e19d68573f@web.de>
Date:   Mon, 20 Jul 2020 14:49:22 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Chao Yu <yuchao0@...wei.com>,
        linux-f2fs-devel@...ts.sourceforge.net
Cc:     linux-kernel@...r.kernel.org, Jaegeuk Kim <jaegeuk@...nel.org>
Subject: Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on
 cc->cpages

>>> Memory allocated for storing compressed pages' poitner should be
>>> released after f2fs_write_compressed_pages(), otherwise it will
>>> cause memory leak issue.
>>
>> * Would an imperative wording be more appropriate (without a typo)
>>   for the change description?
>>
>> * Will the tag “Fixes” become helpful for the commit message?
>
> It looks this is replied from patch-robot? since I found all comments
> you replied are almost the same.

I dare to repeat such suggestions because several patches contain
improvable details (not only in the affected source code).

Regards,
Markus