lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jul 2020 16:06:01 +0200 From: Christoph Hellwig <hch@....de> To: Logan Gunthorpe <logang@...tatee.com> Cc: linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org, Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>, Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>, Max Gurtovoy <maxg@...lanox.com>, Stephen Bates <sbates@...thlin.com> Subject: Re: [PATCH v15 3/9] nvme: Move nvme_passthru_[start|end]() calls to common helper On Thu, Jul 16, 2020 at 02:33:13PM -0600, Logan Gunthorpe wrote: > Introduce a new nvme_execute_passthru_rq() helper which calls > nvme_passthru_[start|end]() around blk_execute_rq(). This ensures > all passthru calls (including nvme_submit_io()) will be wrapped > appropriately. > > nvme_execute_passthru_rq() will also be useful for the nvmet passthru > code. > > Signed-off-by: Logan Gunthorpe <logang@...tatee.com> > Reviewed-by: Sagi Grimberg <sagi@...mberg.me> Looks good, Reviewed-by: Christoph Hellwig <hch@....de> although maybe you could have moved the code you changed in the last patch up already to not just move it after changing it in the last one.
Powered by blists - more mailing lists