linux-kernel - Re: [PATCH] vfio dma_map/unmap: optimized for hugetlbfs pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Jul 2020 22:24:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jay Zhou <jianjay.zhou@...wei.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, alex.williamson@...hat.com,
        cohuck@...hat.com, maoming.maoming@...wei.com,
        jianjay.zhou@...wei.com, weidong.huang@...wei.com
Subject: Re: [PATCH] vfio dma_map/unmap: optimized for hugetlbfs pages

Hi Jay,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on vfio/next]
[also build test ERROR on linux/master linus/master v5.8-rc6 next-20200720]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jay-Zhou/vfio-dma_map-unmap-optimized-for-hugetlbfs-pages/20200720-163157
base:   https://github.com/awilliam/linux-vfio.git next
config: i386-randconfig-m021-20200720 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/mm.h:679,
                    from include/linux/scatterlist.h:8,
                    from include/linux/iommu.h:10,
                    from drivers/vfio/vfio_iommu_type1.c:27:
>> include/linux/huge_mm.h:319:25: error: braced-group within expression allowed only inside a function
     319 | #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; })
         |                         ^
   drivers/vfio/vfio_iommu_type1.c:523:45: note: in expansion of macro 'HPAGE_PMD_SHIFT'
     523 |  {vfio_hugetlbpage_2M, PMD_SIZE, ~((1ULL << HPAGE_PMD_SHIFT) - 1)},
         |                                             ^~~~~~~~~~~~~~~
   include/linux/huge_mm.h:323:25: error: braced-group within expression allowed only inside a function
     323 | #define HPAGE_PUD_SHIFT ({ BUILD_BUG(); 0; })
         |                         ^
   drivers/vfio/vfio_iommu_type1.c:524:45: note: in expansion of macro 'HPAGE_PUD_SHIFT'
     524 |  {vfio_hugetlbpage_1G, PUD_SIZE, ~((1ULL << HPAGE_PUD_SHIFT) - 1)},
         |                                             ^~~~~~~~~~~~~~~

vim +319 include/linux/huge_mm.h

87eaceb3faa59b Yang Shi         2019-09-23  317  
71e3aac0724ffe Andrea Arcangeli 2011-01-13  318  #else /* CONFIG_TRANSPARENT_HUGEPAGE */
d8c37c480678eb Naoya Horiguchi  2012-03-21 @319  #define HPAGE_PMD_SHIFT ({ BUILD_BUG(); 0; })
d8c37c480678eb Naoya Horiguchi  2012-03-21  320  #define HPAGE_PMD_MASK ({ BUILD_BUG(); 0; })
d8c37c480678eb Naoya Horiguchi  2012-03-21  321  #define HPAGE_PMD_SIZE ({ BUILD_BUG(); 0; })
71e3aac0724ffe Andrea Arcangeli 2011-01-13  322  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (31291 bytes)