linux-kernel - Re: [PATCH] fsi: fsi-occ: fix return value check in occ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b62ee5d-a96e-bcf4-e62c-c5575f137eb3@roeck-us.net>
Date:   Mon, 20 Jul 2020 07:44:50 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Xu Wang <vulab@...as.ac.cn>, jk@...abs.org, joel@....id.au,
        alistair@...ple.id.au, eajames@...ux.ibm.com,
        linux-fsi@...ts.ozlabs.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsi: fsi-occ: fix return value check in occ_probe()

On 7/12/20 8:33 PM, Xu Wang wrote:
> In case of error, the function platform_device_register_full()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
> 
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/fsi/fsi-occ.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c
> index 7da9c81759ac..9eeb856c8905 100644
> --- a/drivers/fsi/fsi-occ.c
> +++ b/drivers/fsi/fsi-occ.c
> @@ -555,7 +555,7 @@ static int occ_probe(struct platform_device *pdev)
>  
>  	hwmon_dev_info.id = occ->idx;
>  	hwmon_dev = platform_device_register_full(&hwmon_dev_info);
> -	if (!hwmon_dev)
> +	if (IS_ERR(hwmon_dev))
>  		dev_warn(dev, "failed to create hwmon device\n");
>  
>  	return 0;
>