linux-kernel - Re: [PATCH v8 1/2] dt-bindings: timer: Add Ingenic X1000 OST bindings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5b0e6a88-8eb4-a0e2-3c68-ee606635ecc3@wanyeetech.com>
Date:   Mon, 20 Jul 2020 22:47:13 +0800
From:   Zhou Yanjie <zhouyanjie@...yeetech.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>, robh+dt@...nel.org
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        tglx@...utronix.de, dongsheng.qiu@...enic.com,
        aric.pzqi@...enic.com, rick.tyliu@...enic.com,
        yanfei.li@...enic.com, sernia.zhou@...mail.com,
        zhenwenjin@...il.com, paul@...pouillou.net
Subject: Re: [PATCH v8 1/2] dt-bindings: timer: Add Ingenic X1000 OST
 bindings.

Hi Daniel,

在 2020/7/20 下午3:56, Daniel Lezcano 写道:
> On 19/07/2020 13:42, 周琰杰 (Zhou Yanjie) wrote:
>> Add the OST bindings for the X10000 SoC from Ingenic.
>
> Description: [v8,1/2] dt-bindings: timer: Add Ingenic X1000 OST bindings.
> Applying: dt-bindings: timer: Add Ingenic X1000 OST bindings.
> .git/rebase-apply/patch:91: space before tab in indent.
>      		compatible = "ingenic,x1000-ost";
> .git/rebase-apply/patch:92: space before tab in indent.
>      		reg = <0x12000000 0x3c>;
> .git/rebase-apply/patch:94: space before tab in indent.
>      		#clock-cells = <1>;
> .git/rebase-apply/patch:96: space before tab in indent.
>      		clocks = <&cgu X1000_CLK_OST>;
> .git/rebase-apply/patch:97: space before tab in indent.
>      		clock-names = "ost";
> warning: squelched 3 whitespace errors
> warning: 8 lines add whitespace errors.
>

OK, I will fix this and send v9.

Thanks and best regards!


>> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@...mail.com>
>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
>> Reviewed-by: Paul Cercueil <paul@...pouillou.net>
>> Reviewed-by: Rob Herring <robh@...nel.org>
>> ---
>>
>> Notes:
>>      v1->v2:
>>      No change.
>>      
>>      v2->v3:
>>      Fix wrong parameters in "clocks".
>>      
>>      v3->v4:
>>      1.Rename "ingenic,ost.yaml" to "ingenic,sysost.yaml".
>>      2.Rename "ingenic,ost.h" to "ingenic,sysost.h".
>>      3.Modify the description in "ingenic,sysost.yaml".
>>      
>>      v4->v5:
>>      No change.
>>      
>>      v5->v6:
>>      1.Drop "oneOf" and the blank line.
>>      2.Add "additionalProperties: false".
>>      
>>      v6->v7:
>>      No change.
>>      
>>      v7->v8:
>>      No change.
>>
>>   .../devicetree/bindings/timer/ingenic,sysost.yaml  | 63 ++++++++++++++++++++++
>>   include/dt-bindings/clock/ingenic,sysost.h         | 12 +++++
>>   2 files changed, 75 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
>>   create mode 100644 include/dt-bindings/clock/ingenic,sysost.h
>>
>> diff --git a/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml b/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
>> new file mode 100644
>> index 000000000000..1dae2e538725
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
>> @@ -0,0 +1,63 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/timer/ingenic,sysost.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Bindings for SYSOST in Ingenic XBurst family SoCs
>> +
>> +maintainers:
>> +  - 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
>> +
>> +description:
>> +  The SYSOST in an Ingenic SoC provides one 64bit timer for clocksource
>> +  and one or more 32bit timers for clockevent.
>> +
>> +properties:
>> +  "#size-cells":
>> +    const: 1
>> +
>> +  compatible:
>> +    enum:
>> +      - ingenic,x1000-ost
>> +      - ingenic,x2000-ost
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    const: ost
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +required:
>> +  - "#clock-cells"
>> +  - compatible
>> +  - reg
>> +  - clocks
>> +  - clock-names
>> +  - interrupts
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/clock/x1000-cgu.h>
>> +
>> +    ost: timer@...00000 {
>> +    		compatible = "ingenic,x1000-ost";
>> +    		reg = <0x12000000 0x3c>;
>> +
>> +    		#clock-cells = <1>;
>> +
>> +    		clocks = <&cgu X1000_CLK_OST>;
>> +    		clock-names = "ost";
>> +
>> +    		interrupt-parent = <&cpuintc>;
>> +    		interrupts = <3>;
>> +    	};
>> +...
>> diff --git a/include/dt-bindings/clock/ingenic,sysost.h b/include/dt-bindings/clock/ingenic,sysost.h
>> new file mode 100644
>> index 000000000000..9ac88e90babf
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/ingenic,sysost.h
>> @@ -0,0 +1,12 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * This header provides clock numbers for the ingenic,tcu DT binding.
>> + */
>> +
>> +#ifndef __DT_BINDINGS_CLOCK_INGENIC_OST_H__
>> +#define __DT_BINDINGS_CLOCK_INGENIC_OST_H__
>> +
>> +#define OST_CLK_PERCPU_TIMER	0
>> +#define OST_CLK_GLOBAL_TIMER	1
>> +
>> +#endif /* __DT_BINDINGS_CLOCK_INGENIC_OST_H__ */
>>
>