linux-kernel - Re: [PATCH] csky: Fix build with upstream gcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Jul 2020 00:05:41 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Joerg Roedel <joro@...tes.org>, linux-csky@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH] csky: Fix build with upstream gcc

Thx Joerg & Guenter,

Cool work!

Acked-by: Guo Ren <guoren@...nel.org>

Approve to next branch.

On Tue, Jul 21, 2020 at 9:21 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On Tue, Jul 21, 2020 at 01:23:14PM +0200, Joerg Roedel wrote:
> > From: Joerg Roedel <jroedel@...e.de>
> >
> > Building a kernel for the CSKY architecture with CONFIG_FRAME_POINTER
> > set requires a gcc supporting the non-upstream '-mbacktrace' option.
> > Check for the '-mbacktrace' option before enabling CONFIG_FRAMEPOINTER
> > and fix building CSKY with an upstream gcc compiler.
> >
> > Signed-off-by: Joerg Roedel <jroedel@...e.de>
>
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> Tested-by: Guenter Roeck <linux@...ck-us.net>
>
> > ---
> >  arch/csky/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
> > index bd31ab12f77d..1622e1c56026 100644
> > --- a/arch/csky/Kconfig
> > +++ b/arch/csky/Kconfig
> > @@ -8,7 +8,7 @@ config CSKY
> >       select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> >       select ARCH_USE_BUILTIN_BSWAP
> >       select ARCH_USE_QUEUED_RWLOCKS if NR_CPUS>2
> > -     select ARCH_WANT_FRAME_POINTERS if !CPU_CK610
> > +     select ARCH_WANT_FRAME_POINTERS if (!CPU_CK610 && STACKTRACE_SUPPORT)
> >       select COMMON_CLK
> >       select CLKSRC_MMIO
> >       select CSKY_MPINTC if CPU_CK860
> > @@ -125,7 +125,7 @@ config MMU
> >       def_bool y
> >
> >  config STACKTRACE_SUPPORT
> > -     def_bool y
> > +     def_bool $(success,echo 'int foo(void) { return 0; }' | $(CC) -mbacktrace -x c - -c -o /dev/null)
> >
> >  config TIME_LOW_RES
> >       def_bool y
> > --
> > 2.27.0
> >



-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/