linux-kernel - Re: [PATCH] net: dsa: Add protocol support for 802.1AD when adding or deleting vlan for dsa switch and port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eaf6e25a-4e64-1ffe-972a-9d309d307294@gmail.com>
Date:   Tue, 21 Jul 2020 10:55:17 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     hongbo.wang@....com, xiaoliang.yang_1@....com,
        allan.nielsen@...rochip.com, po.liu@....com,
        claudiu.manoil@....com, alexandru.marginean@....com,
        vladimir.oltean@....com, leoyang.li@....com, mingkai.hu@....com,
        andrew@...n.ch, vivien.didelot@...il.com, davem@...emloft.net,
        jiri@...nulli.us, idosch@...sch.org, kuba@...nel.org,
        vinicius.gomes@...el.com, nikolay@...ulusnetworks.com,
        roopa@...ulusnetworks.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, horatiu.vultur@...rochip.com,
        alexandre.belloni@...tlin.com, UNGLinuxDriver@...rochip.com,
        linux-devel@...ux.nxdi.nxp.com
Subject: Re: [PATCH] net: dsa: Add protocol support for 802.1AD when adding or
 deleting vlan for dsa switch and port

On 7/21/20 4:02 AM, hongbo.wang@....com wrote:
> From: "hongbo.wang" <hongbo.wang@....com>
> 
> the following command will be supported:
> Add VLAN:
>     ip link add link swp1 name swp1.100 type vlan protocol 802.1ad id 100
> Delete VLAN:
>     ip link del link swp1 name swp1.100
> 
> when adding vlan, this patch only set protocol for user port,
> cpu port don't care it, so set parameter proto to 0 for cpu port.

My previous feedback has been partially addressed, can you also post the
switch driver changes that are going to implement the driver side
changes? Presumably you must act on the 802.1AD programming request in
the switch driver somehow, right?
-- 
Florian