linux-kernel - Re: [PATCH] iio: adxl372: change indentation for of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jul 2020 21:36:19 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH] iio: adxl372: change indentation for of_table

On Mon, Jul 20, 2020 at 4:49 PM Alexandru Ardelean
<alexandru.ardelean@...log.com> wrote:
>
> The change is mostly stylistic. The table should be indented with tabs
> instead of spaces.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
> ---
>  drivers/iio/accel/adxl372_spi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/adxl372_spi.c b/drivers/iio/accel/adxl372_spi.c
> index 3ef7e3a4804e..7741890674c1 100644
> --- a/drivers/iio/accel/adxl372_spi.c
> +++ b/drivers/iio/accel/adxl372_spi.c
> @@ -40,8 +40,8 @@ static const struct spi_device_id adxl372_spi_id[] = {
>  MODULE_DEVICE_TABLE(spi, adxl372_spi_id);
>
>  static const struct of_device_id adxl372_of_match[] = {
> -        { .compatible = "adi,adxl372" },
> -        { },
> +       { .compatible = "adi,adxl372" },
> +       { },

Please, drop useless and even bad in very rare cases comma at the
terminator line.

>  };
>  MODULE_DEVICE_TABLE(of, adxl372_of_match);
>
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko