lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Jul 2020 21:11:29 +0200 From: Peter Zijlstra <peterz@...radead.org> To: Ira Weiny <ira.weiny@...el.com> Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Andy Lutomirski <luto@...nel.org>, Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, Dan Williams <dan.j.williams@...el.com>, Vishal Verma <vishal.l.verma@...el.com>, Andrew Morton <akpm@...ux-foundation.org>, Fenghua Yu <fenghua.yu@...el.com>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-nvdimm@...ts.01.org, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, linux-kselftest@...r.kernel.org Subject: Re: [PATCH RFC V2 17/17] x86/entry: Preserve PKRS MSR across exceptions On Tue, Jul 21, 2020 at 11:01:34AM -0700, Ira Weiny wrote: > On Fri, Jul 17, 2020 at 11:30:41AM +0200, Peter Zijlstra wrote: > > On Fri, Jul 17, 2020 at 12:20:56AM -0700, ira.weiny@...el.com wrote: > > > +static void noinstr idt_save_pkrs(idtentry_state_t state) > > > > noinstr goes in the same place you would normally put inline, that's > > before the return type, not after it. > > > > Sorry about that. But that does not look to be consistent. > > 10:57:35 > git grep 'noinstr' arch/x86/entry/common.c > ... > arch/x86/entry/common.c:idtentry_state_t noinstr idtentry_enter(struct pt_regs *regs) > arch/x86/entry/common.c:void noinstr idtentry_exit(struct pt_regs *regs, idtentry_state_t state) > arch/x86/entry/common.c:void noinstr idtentry_enter_user(struct pt_regs *regs) > arch/x86/entry/common.c:void noinstr idtentry_exit_user(struct pt_regs *regs) > ... > > Are the above 'wrong'? Is it worth me sending a patch? I think I already fixed all those, please check tip/master.
Powered by blists - more mailing lists