linux-kernel - Re: [PATCH v6 net-next] net: hyperv: Add attributes to show TX indirection table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78ca93f5-bb3f-96f9-17c5-3c1855b11a40@gmail.com>
Date:   Tue, 21 Jul 2020 12:24:07 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, Chi Song <Song.Chi@...rosoft.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        David Miller <davem@...emloft.net>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 net-next] net: hyperv: Add attributes to show TX
 indirection table

On 7/21/20 12:21 PM, Jakub Kicinski wrote:
> On Tue, 21 Jul 2020 04:58:59 +0000 Chi Song wrote:
>> An imbalanced TX indirection table causes netvsc to have low
>> performance. This table is created and managed during runtime. To help
>> better diagnose performance issues caused by imbalanced tables, add
>> device attributes to show the content of TX indirection tables.
>>
>> Signed-off-by: Chi Song <chisong@...rosoft.com>
> 
> Sorry for waiting until v6 but sysfs feel like a very strange place to
> expose this. Especially under the netdev, not the bus device.
> 
> This looks like device specific state, perhaps ethtool -d is a more
> appropriate place?

Agreed, or a devlink resource maybe?
-- 
Florian