linux-kernel - Re: [PATCH] net: ethernet: ti: add NETIF_F_HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0cef407-9340-2d4d-9fa7-d708f5568d25@ti.com>
Date:   Tue, 21 Jul 2020 23:05:48 +0300
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <kuba@...nel.org>, <m-karicheri2@...com>,
        <nsekhar@...com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: ethernet: ti: add NETIF_F_HW_TC hw feature flag for
 taprio offload

hi David,

On 18/07/2020 04:47, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko@...com>
> Date: Fri, 17 Jul 2020 15:19:32 +0300
> 
>> From: Murali Karicheri <m-karicheri2@...com>
>>
>> Currently drive supports taprio offload which is a tc feature offloaded
>> to cpsw hardware. So driver has to set the hw feature flag, NETIF_F_HW_TC
>> in the net device to be compliant. This patch adds the flag.
>>
>> Fixes: 8127224c2708 ("ethernet: ti: am65-cpsw-qos: add TAPRIO offload support")
>> Signed-off-by: Murali Karicheri <m-karicheri2@...com>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> 
> How was the commit adding TAPRIO support even tested since without the
> NETIF_F_HW_TC bit set tc_can_offload() always returns false?
> 

The sch_taprio doesn't check for NETIF_F_HW_TC (no calls of tc_can_offload()).
It only checks for !ndo_setup_tc(). Therefore our basic offload tests are working.

It's not critical patch.

-- 
Best regards,
grygorii