linux-kernel - Re: [PATCH 1/2] rtc: ds1374: fix RTC_DRV_DS1374

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2d322558-d60e-6da2-3434-389959d222b2@infradead.org>
Date:   Mon, 20 Jul 2020 19:39:46 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alessandro Zummo <a.zummo@...ertech.it>
Cc:     linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] rtc: ds1374: fix RTC_DRV_DS1374_WDT dependencies

On 7/20/20 12:52 AM, Alexandre Belloni wrote:
> It is not enough to select WATCHDOG_CORE, the watchdog part of the driver
> now also depends on WATCHDOG. This is currently the best we can do because
> alarm support and watchdog support are mutually exclusive.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
>  drivers/rtc/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index c25d51f35f0c..2753e0f54cc3 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -281,8 +281,8 @@ config RTC_DRV_DS1374
>  
>  config RTC_DRV_DS1374_WDT
>  	bool "Dallas/Maxim DS1374 watchdog timer"
> -	depends on RTC_DRV_DS1374
> -	select WATCHDOG_CORE if WATCHDOG
> +	depends on RTC_DRV_DS1374 && WATCHDOG
> +	select WATCHDOG_CORE
>  	help
>  	  If you say Y here you will get support for the
>  	  watchdog timer in the Dallas Semiconductor DS1374
> 


-- 
~Randy