linux-kernel - Re: [PATCH v2 1/2] KVM: PPC: Book3S HV: move kvmppc_svm_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200721212813.GF7339@oc0525413822.ibm.com>
Date:   Tue, 21 Jul 2020 14:28:13 -0700
From:   Ram Pai <linuxram@...ibm.com>
To:     Laurent Dufour <ldufour@...ux.ibm.com>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        kvm-ppc@...r.kernel.org, mpe@...erman.id.au, paulus@...ba.org,
        sukadev@...ux.ibm.com, bauerman@...ux.ibm.com,
        bharata@...ux.ibm.com, Paul Mackerras <paulus@...abs.org>
Subject: Re: [PATCH v2 1/2] KVM: PPC: Book3S HV: move kvmppc_svm_page_out up

On Tue, Jul 21, 2020 at 12:42:01PM +0200, Laurent Dufour wrote:
> kvmppc_svm_page_out() will need to be called by kvmppc_uvmem_drop_pages()
> so move it upper in this file.
> 
> Furthermore it will be interesting to call this function when already
> holding the kvm->arch.uvmem_lock, so prefix the original function with __
> and remove the locking in it, and introduce a wrapper which call that
> function with the lock held.
> 
> There is no functional change.

Reviewed-by: Ram Pai <linuxram@...ibm.com>

> 
> Cc: Ram Pai <linuxram@...ibm.com>
> Cc: Bharata B Rao <bharata@...ux.ibm.com>
> Cc: Paul Mackerras <paulus@...abs.org>
> Signed-off-by: Laurent Dufour <ldufour@...ux.ibm.com>
> ---

RP