linux-kernel - Re: [PATCH v4 3/6] dt-bindings: remoteproc: Add common TI SCI rproc bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <deead680-9699-9de5-84af-059c31a4bbd4@ti.com>
Date:   Tue, 21 Jul 2020 17:44:04 -0500
From:   Suman Anna <s-anna@...com>
To:     Rob Herring <robh+dt@...nel.org>, Lokesh Vutla <lokeshvutla@...com>
CC:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        "open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM" 
        <linux-remoteproc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/6] dt-bindings: remoteproc: Add common TI SCI rproc
 bindings

Hi Rob,

On 7/21/20 11:40 AM, Suman Anna wrote:
> Hi Rob,
> 
> On 7/21/20 10:53 AM, Rob Herring wrote:
>> On Fri, Jul 17, 2020 at 5:48 PM Suman Anna <s-anna@...com> wrote:
>>>
>>> Add a bindings document that lists the common TI SCI properties
>>> used by the K3 R5F and DSP remoteproc devices.
>>>
>>> Signed-off-by: Suman Anna <s-anna@...com>
>>> ---
>>> v4: Addressed both of Rob's review comments on ti,sci-proc-ids property
>>> v3: https://patchwork.kernel.org/patch/11602317/
>>>
>>>   .../bindings/remoteproc/ti,k3-sci-proc.yaml   | 48 +++++++++++++++++++
>>>   1 file changed, 48 insertions(+)
>>>   create mode 100644 
>>> Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml 
>>> b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>> new file mode 100644
>>> index 000000000000..0dca2ffdbc48
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>> @@ -0,0 +1,48 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/remoteproc/ti,k3-sci-proc.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Common TI K3 remote processor device bindings
>>> +
>>> +maintainers:
>>> +  - Suman Anna <s-anna@...com>
>>> +
>>> +description: |
>>> +  The TI K3 family of SoCs usually have one or more remote processor 
>>> sub-systems
>>> +  like the dual-core R5F sub-system or a C66x or C71x DSP processor 
>>> subsystem.
>>> +  The device management of these remote processors is managed by a 
>>> dedicated
>>> +  System Processor, and the communication with that processor is 
>>> managed through
>>> +  the TI-SCI protocol.
>>> +
>>> +  Each remote processor device node should define a common set of 
>>> properties
>>> +  that allows the System Processor firmware to perform the device 
>>> management
>>> +  such as powering the IPs, asserting/deasserting the resets for 
>>> each of these
>>> +  processors.
>>> +
>>> +properties:
>>> +  ti,sci:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle
>>> +    description:
>>> +      Should be a phandle to the TI-SCI System Controller node
>>> +
>>> +  ti,sci-dev-id:
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +    description: |
>>> +      Should contain the TI-SCI device id corresponding to the 
>>> remote processor
>>> +      core. Please refer to the corresponding System Controller 
>>> documentation
>>> +      for valid values.
>>
>> These also apply on Lokesh's series converting ti,sci-int[ra]
>> bindings. Please rework to use for both.
> 
> OK.

OK, I have reworked for this and posted it [1] as part of v5 of this series.

regards
Suman

[1] https://patchwork.kernel.org/patch/11676821/

> 
>>
>>> +
>>> +  ti,sci-proc-ids:
>>> +    description: Should contain a single tuple of <proc_id host_id>.
>>> +    $ref: /schemas/types.yaml#/definitions/uint32-array
>>> +    items:
>>> +      - description: TI-SCI processor id for the remote processor 
>>> device
>>> +      - description: TI-SCI host id to which processor control 
>>> ownership
>>> +                     should be transferred to
> 
> This property is not required for the ti,sci-int[ra].
> 
> I can plan to move this to a common location like 
> Documentation/devicetree/bindings/arm/keystone/ and let the individual 
> bindings define the required properties. Does that sound ok to you?
> 
> regards
> Suman
> 
>>> +
>>> +required:
>>> +  - ti,sci
>>> +  - ti,sci-dev-id
>>> +  - ti,sci-proc-ids
>>> -- 
>>> 2.26.0
>>>
>