linux-kernel - Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jul 2020 07:00:47 +0200
From:   Christoph Hellwig <hch@....de>
To:     Richard Weinberger <richard.weinberger@...il.com>
Cc:     Artem Bityutskiy <dedekind1@...il.com>,
        Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        linux-raid@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>,
        Richard Weinberger <richard@....at>,
        LKML <linux-kernel@...r.kernel.org>, linux-block@...r.kernel.org,
        Song Liu <song@...nel.org>,
        device-mapper development <dm-devel@...hat.com>,
        linux-mtd@...ts.infradead.org, linux-mm@...ck.org,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        cgroups mailinglist <cgroups@...r.kernel.org>,
        drbd-dev@...ts.linbit.com
Subject: Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init

On Mon, Jul 20, 2020 at 11:27:57PM +0200, Richard Weinberger wrote:
> On Mon, Jul 20, 2020 at 2:37 PM Artem Bityutskiy <dedekind1@...il.com> wrote:
> >
> > On Mon, 2020-07-20 at 14:07 +0200, Christoph Hellwig wrote:
> > > What about jffs2 and blk2mtd raw block devices?
> 
> I don't worry much about blk2mtd.
> 
> > If my memory serves me correctly JFFS2 did not mind readahead.
> 
> This covers my knowledge too.
> I fear enabling readahead on JFFS2 will cause performance issues, this
> filesystem
> is mostly used on small and slow NOR devices.

I'm going to wait for Hans for feedback on vboxsf, but in doubt I'll
ust add a prep patch or fold for this one to explicit set ra_pages to 0
with a comment then.