linux-kernel - Re: [PATCH] PCI/ATS: PASID and PRI are only enumerated in PF devices.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Jul 2020 12:53:27 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ashok Raj <ashok.raj@...el.com>, linux-pci@...r.kernel.org,
        Bjorn Helgaas <helgaas@...nel.org>,
        Joerg Roedel <joro@...tes.org>, Lu Baolu <baolu.lu@...el.com>
Cc:     kbuild-all@...ts.01.org, Ashok Raj <ashok.raj@...el.com>,
        stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        iommu@...ts.linux-foundation.org
Subject: Re: [PATCH] PCI/ATS: PASID and PRI are only enumerated in PF devices.

Hi Ashok,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on iommu/next linux/master linus/master v5.8-rc6 next-20200720]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ashok-Raj/PCI-ATS-PASID-and-PRI-are-only-enumerated-in-PF-devices/20200721-004510
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

>> drivers/pci/ats.c:471:6: warning: no previous prototype for 'pci_pri_supported' [-Wmissing-prototypes]
     471 | bool pci_pri_supported(struct pci_dev *pdev)
         |      ^~~~~~~~~~~~~~~~~
   drivers/pci/ats.c: In function 'pci_pri_supported':
>> drivers/pci/ats.c:474:30: error: 'struct pci_dev' has no member named 'pri_cap'; did you mean 'pcie_cap'?
     474 |  return !!(pci_physfn(pdev)->pri_cap);
         |                              ^~~~~~~
         |                              pcie_cap
>> drivers/pci/ats.c:475:1: warning: control reaches end of non-void function [-Wreturn-type]
     475 | }
         | ^

vim +474 drivers/pci/ats.c

   463	
   464	/**
   465	 * pci_pri_supported - Check if PRI is supported.
   466	 * @pdev: PCI device structure
   467	 *
   468	 * Returns false when no PRI capability is present.
   469	 * Returns true if PRI feature is supported and enabled
   470	 */
 > 471	bool pci_pri_supported(struct pci_dev *pdev)
   472	{
   473		/* VFs share the PF PRI configuration */
 > 474		return !!(pci_physfn(pdev)->pri_cap);
 > 475	}
   476	EXPORT_SYMBOL_GPL(pci_pri_supported);
   477	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (50557 bytes)