linux-kernel - Re: [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1df7901-35ef-af8a-b852-e5e89ababf01@al2klimov.de>
Date:   Tue, 21 Jul 2020 08:43:00 +0200
From:   "Alexander A. Klimov" <grandmaster@...klimov.de>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Jonathan Corbet <corbet@....net>, santosh.shilimkar@...cle.com,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, rds-devel@....oracle.com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for v5.9] RDS: Replace HTTP links with HTTPS ones



Am 21.07.20 um 08:05 schrieb Leon Romanovsky:
> On Mon, Jul 20, 2020 at 11:34:00PM +0200, Alexander A. Klimov wrote:
>>
>>
>> Am 20.07.20 um 18:48 schrieb Leon Romanovsky:
>>> On Mon, Jul 20, 2020 at 08:36:35AM -0600, Jonathan Corbet wrote:
>>>> On Mon, 20 Jul 2020 17:07:16 +0300
>>>> Leon Romanovsky <leon@...nel.org> wrote:
>>>>
>>>>>> Do *you* want to review that megapatch?  The number of issues that have
>> This question is... interesting.
>> And no, I would not.
> 
> You are EXPECTED to review your work prior sending to the mailing list.
I meant I wouldn't review *one big* patch.
I didn't mean my actually sent smaller ones.

> 
>>
>>>>>> come up make it clear that these patches do, indeed, need review...
>>>>>
>>>>> Can you point me to the issues?
>>>>> What can go wrong with such a simple replacement?
>>>>
>>>> Some bits of the conversation:
>>>>
>>>>     https://lore.kernel.org/lkml/20200626110219.7ae21265@lwn.net/
>>>>     https://lore.kernel.org/lkml/20200626110706.7b5d4a38@lwn.net/
>>>>     https://lore.kernel.org/lkml/20200705142506.1f26a7e0@lwn.net/
>>>>     https://lore.kernel.org/lkml/20200713114321.783f0ae6@lwn.net/
>>>>     https://lore.kernel.org/lkml/202007081531.085533FC5@keescook/
>>>>
>>>> etc.
>>>
>>> After reading your links and especially this one.
>>> https://lore.kernel.org/lkml/20200713114321.783f0ae6@lwn.net/
>>> I don't understand why are we still seeing these patches?
>>>
>>> I gave to the author comments too, which were ignored.
>>> https://patchwork.kernel.org/patch/11644683/#23466547
>> I've added SPDXing (the automated way of course ;) ) to my todo list.
> 
> OMG, why don't you listen? We don't want your automatic patches.
Wrong.
*Some of you* don't want my automatic patches.
And *some others* already applied them and said thanks.

> 
> Thanks
> 
>>
>>>
>>> Thanks
>>>
>>>>
>>>> jon