linux-kernel - Re: [PATCH net-next v2 0/4] net: dsa: Setup dsa_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200720.164948.1294578504944144052.davem@davemloft.net>
Date:   Mon, 20 Jul 2020 16:49:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        kuba@...nel.org, jiri@...lanox.com, edumazet@...gle.com,
        ap420073@...il.com, xiyou.wangcong@...il.com, maximmi@...lanox.com,
        richardcochran@...il.com, mkubecek@...e.cz,
        linux-kernel@...r.kernel.org, olteanv@...il.com
Subject: Re: [PATCH net-next v2 0/4] net: dsa: Setup dsa_netdev_ops

From: Florian Fainelli <f.fainelli@...il.com>
Date: Sun, 19 Jul 2020 20:49:50 -0700

> This patch series addresses the overloading of a DSA CPU/management
> interface's netdev_ops for the purpose of providing useful information
> from the switch side.
> 
> Up until now we had duplicated the existing netdev_ops structure and
> added specific function pointers to return information of interest. Here
> we have a more controlled way of doing this by involving the specific
> netdev_ops function pointers that we want to be patched, which is easier
> for auditing code in the future. As a byproduct we can now maintain
> netdev_ops pointer comparisons which would be failing before (no known
> in tree problems because of that though).
> 
> Let me know if this approach looks reasonable to you and we might do the
> same with our ethtool_ops overloading as well.

This looks good to me, series applied.

And yes, doing something similar for ethtool_ops is probably a good idea
too.