linux-kernel - RE: [PATCH][next] phy: samsung-ufs: fix check on failed devm_clk_get call for rx1_symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <042e01d65ef8$d34fefe0$79efcfa0$@samsung.com>
Date:   Tue, 21 Jul 2020 06:19:40 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Colin King'" <colin.king@...onical.com>,
        "'Kishon Vijay Abraham I'" <kishon@...com>,
        "'Vinod Koul'" <vkoul@...nel.org>,
        "'Seungwon Jeon'" <essuuj@...il.com>,
        "'Kiwoong Kim'" <kwmad.kim@...sung.com>
Cc:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH][next] phy: samsung-ufs: fix check on failed
 devm_clk_get call for rx1_symbol_clk

Hello Colin,

> -----Original Message-----
> From: Colin King <colin.king@...onical.com>
> Sent: 20 July 2020 22:00
> To: Kishon Vijay Abraham I <kishon@...com>; Vinod Koul <vkoul@...nel.org>;
> Seungwon Jeon <essuuj@...il.com>; Kiwoong Kim
> <kwmad.kim@...sung.com>; Alim Akhtar <alim.akhtar@...sung.com>
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH][next] phy: samsung-ufs: fix check on failed devm_clk_get call
> for rx1_symbol_clk
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The check to see if the call to devm_clk_get on rx1_symbol_clk is checking the
> wrong variable, this looks like a copy-paste error. Fix this to check
> phy->rx1_symbol instead of phy->rx0_symbol.
> 
This fix is already posted by Gustavo [1]
[1] https://lkml.org/lkml/2020/7/20/617

Thanks!

> Addresses-Coverity: ("Copy-paste error")
> Fixes: bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung SoC")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/phy/samsung/phy-samsung-ufs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/samsung/phy-samsung-ufs.c
> b/drivers/phy/samsung/phy-samsung-ufs.c
> index 43ef77d1d96c..9832599a0283 100644
> --- a/drivers/phy/samsung/phy-samsung-ufs.c
> +++ b/drivers/phy/samsung/phy-samsung-ufs.c
> @@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct
> samsung_ufs_phy *phy)
>  	}
> 
>  	phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk");
> -	if (IS_ERR(phy->rx0_symbol_clk)) {
> +	if (IS_ERR(phy->rx1_symbol_clk)) {
>  		dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n");
>  		return PTR_ERR(phy->rx1_symbol_clk);
>  	}
> --
> 2.27.0