linux-kernel - Re: [PATCH V3] clk: vc5: Add memory check to prevent oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <159532318111.3847286.6874293188283317151@swboyd.mtv.corp.google.com>
Date:   Tue, 21 Jul 2020 02:19:41 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Adam Ford <aford173@...il.com>, linux-clk@...r.kernel.org
Cc:     dan.carpenter@...cle.com, luca@...aceresoli.net,
        aford@...conembedded.com, Adam Ford <aford173@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] clk: vc5: Add memory check to prevent oops

Quoting Adam Ford (2020-07-16 05:26:20)
> When getting the names of the child nodes, kasprintf is used to
> allocate memory which is used to create the string for the node
> name.  Unfortunately, there is no memory check to determine
> if this allocation fails, it may cause an error when trying
> to get child node name.
> 
> This patch will check if the memory allocation fails, and returns
> and -ENOMEM error instead of blindly moving on.
> 
> Fixes: 260249f929e8 ("clk: vc5: Enable addition output configurations of the Versaclock")
> 
> Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Adam Ford <aford173@...il.com>
> Reviewed-by: Luca Ceresoli <luca@...aceresoli.net>
> ---
> V3:   Fix spelling error, and use the style of checking (!variable) instead of
>       (variable == NULL)
> 
> V2:   Fix an issue where a goto was going to use an unitialized variable.

Is the patch from Colin also needed?
https://lore.kernel.org/r/20200625132736.88832-1-colin.king@canonical.com