linux-kernel - Re: [PATCH net] net: bcmgenet: add missed clk_disable_unprepare in bcmgenet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200720.170426.1912395025653130693.davem@davemloft.net>
Date:   Mon, 20 Jul 2020 17:04:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     zhangchangzhong@...wei.com
Cc:     opendmb@...il.com, f.fainelli@...il.com, kuba@...nel.org,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: bcmgenet: add missed clk_disable_unprepare in
 bcmgenet_probe

From: Zhang Changzhong <zhangchangzhong@...wei.com>
Date: Mon, 20 Jul 2020 17:36:34 +0800

> The driver forgets to call clk_disable_unprepare() in error path after
> a success calling for clk_prepare_enable().
> 
> Fix to goto err_clk_disable if clk_prepare_enable() is successful.
> 
> Fixes: c80d36ff63a5 ("net: bcmgenet: Use devm_clk_get_optional() to get the clocks")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

Applied.