linux-kernel - Re: [PATCH v1] ethernet: myri10ge: use generic power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Jul 2020 18:01:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vaibhavgupta40@...il.com
Cc:     helgaas@...nel.org, bhelgaas@...gle.com, bjorn@...gaas.com,
        vaibhav.varodek@...il.com, christopher.lee@...i.com,
        kuba@...nel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        skhan@...uxfoundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH v1] ethernet: myri10ge: use generic power management

From: Vaibhav Gupta <vaibhavgupta40@...il.com>
Date: Mon, 20 Jul 2020 21:49:31 +0530

> Drivers using legacy PM have to manage PCI states and device's PM states
> themselves. They also need to take care of configuration registers.
> 
> With improved and powerful support of generic PM, PCI Core takes care of
> above mentioned, device-independent, jobs.
> 
> This driver makes use of PCI helper functions like
> pci_save/restore_state(), pci_enable/disable_device(),
> pci_set_power_state() and pci_set_master() to do required operations. In
> generic mode, they are no longer needed.
> 
> Change function parameter in both .suspend() and .resume() to
> "struct device*" type. Use to_pci_dev() and dev_get_drvdata() to get
> "struct pci_dev*" variable and drv data.
> 
> Compile-tested only.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@...il.com>

Applied, thank you.