linux-kernel - Re: [PATCH] xtensa: fix closing endif comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200721102042.GD802087@linux.ibm.com>
Date:   Tue, 21 Jul 2020 13:24:09 +0300
From:   Mike Rapoport <rppt@...ux.ibm.com>
To:     Max Filippov <jcmvbkbc@...il.com>
Cc:     linux-xtensa@...ux-xtensa.org, Chris Zankel <chris@...kel.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xtensa: fix closing endif comment

On Mon, Jul 20, 2020 at 07:47:51PM -0700, Max Filippov wrote:
> Commit 8f74afa22d9b ("xtensa: switch to generic version of pte
> allocation") introduced the following build warning for xtensa
>   arch/xtensa/include/asm/pgalloc.h:67:8: warning: extra tokens at end of
>   #endif directive [-Wendif-labels]
> Fix #endif comment.

Oops :)

> Cc: Mike Rapoport <rppt@...ux.ibm.com>
> Fixes: 8f74afa22d9b ("xtensa: switch to generic version of pte allocation")
> Signed-off-by: Max Filippov <jcmvbkbc@...il.com>

Reviewed-by: Mike Rapoport <rppt@...ux.ibm.com>

> ---
>  arch/xtensa/include/asm/pgalloc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/xtensa/include/asm/pgalloc.h b/arch/xtensa/include/asm/pgalloc.h
> index 699a8fdf9005..d3a22da4d2c9 100644
> --- a/arch/xtensa/include/asm/pgalloc.h
> +++ b/arch/xtensa/include/asm/pgalloc.h
> @@ -64,6 +64,6 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm)
>  }
>  
>  #define pmd_pgtable(pmd) pmd_page(pmd)
> -#endif CONFIG_MMU
> +#endif /* CONFIG_MMU */
>  
>  #endif /* _XTENSA_PGALLOC_H */
> -- 
> 2.20.1
> 

-- 
Sincerely yours,
Mike.