linux-kernel - Re: [PATCH net-next v2 1/2] hinic: add support to handle hw abnormal event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc2ee43e-8342-0b9f-6cc1-4eb19cbb93f5@huawei.com>
Date:   Tue, 21 Jul 2020 09:24:17 +0800
From:   "luobin (L)" <luobin9@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <luoxianjun@...wei.com>,
        <yin.yinshi@...wei.com>, <cloud.wangxiaoyun@...wei.com>,
        <chiqijun@...wei.com>
Subject: Re: [PATCH net-next v2 1/2] hinic: add support to handle hw abnormal
 event

On 2020/7/21 2:13, Jakub Kicinski wrote:
> On Sat, 18 Jul 2020 16:58:29 +0800 Luo bin wrote:
>> add support to handle hw abnormal event such as hardware failure,
>> cable unplugged,link error
>>
>> Signed-off-by: Luo bin <luobin9@...wei.com>
>> ---
>> V1~V2: add link extended state
>> V0~V1: fix auto build test WARNING
> 
> I don't understand what you think devlink health is missing.
> 
> If it is really missing some functionality you require you have to work
> on extending it.
> 
> Dumping error event state into kernel logs when we have specific
> infrastructure built to address this sort of needs won't fly.
> .
> 
Okay, I'll try to implement these functionality based on devlink health.