linux-kernel - Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87365lozec.fsf@kernel.org>
Date:   Tue, 21 Jul 2020 14:55:55 +0300
From:   Felipe Balbi <balbi@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>,
        "gregkh\@linuxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-arm-kernel\@lists.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb\@vger.kernel.org" <linux-usb@...r.kernel.org>,
        Ben Dooks <ben@...tec.co.uk>
Subject: Re: [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2

Hi,

Lee Jones <lee.jones@...aro.org> writes:
> On Tue, 21 Jul 2020, Felipe Balbi wrote:
>
>> Minas Harutyunyan <Minas.Harutyunyan@...opsys.com> writes:
>> 
>> > Hi Felipe,
>> >
>> > On 7/21/2020 1:43 PM, Felipe Balbi wrote:
>> >> Minas Harutyunyan <Minas.Harutyunyan@...opsys.com> writes:
>> >> 
>> >>> On 7/15/2020 1:32 PM, Lee Jones wrote:
>> >>>> The value obtained from GINTSTS2 should be masked with the GINTMSK2
>> >>>> value.  Looks like this has been broken since
>> >>>> dwc2_gadget_wkup_alert_handler() was added back in 2018.
>> >>>>
>> >>>> Also fixes the following W=1 warning:
>> >>>>
>> >>>>    drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’:
>> >>>>    drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable]
>> >>>>    259 | u32 gintmsk2;
>> >>>>    | ^~~~~~~~
>> >>>>
>> >>>> Cc: Minas Harutyunyan <hminas@...opsys.com>
>> >>>> Cc: Ben Dooks <ben@...tec.co.uk>
>> >>>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
>> >>>> Signed-off-by: Lee Jones <lee.jones@...aro.org>
>> >>>
>> >>> Acked-by: Minas Harutyunyan <hminas@...opsys.com>
>> >> 
>> >> Should I apply the entire series or only 1/8?
>> >> 
>> > In this series only 2 patches are related to dwc2, which I'm already Acked:
>> >
>> > [PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2
>> > [PATCH v2 2/8] usb: dwc2: gadget: Avoid pointless read of EP control 
>> > register
>> >
>> > I can't acked other patches from this series, because they are not 
>> > related to dwc2.
>> 
>> heh, I saw that after sending the email, sorry :-)
>
> Also, all patches are already in -next, courtesy of Greg.

Cool, I'll rebase on top of Greg's branch

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)