linux-kernel - Re: [PATCH v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <16aa9f4a-583e-2fd1-c14f-a3b2a6228436@huawei.com>
Date:   Tue, 21 Jul 2020 20:34:20 +0800
From:   Bixuan Cui <cuibixuan@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <stephen@...workplumber.org>, <kuba@...nel.org>,
        <linux-next@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <jdmason@...zu.us>,
        <christophe.jaillet@...adoo.fr>, <john.wanghui@...wei.com>
Subject: Re: [PATCH v2] net: neterion: vxge: reduce stack usage in
 VXGE_COMPLETE_VPATH_TX



On 2020/7/21 9:38, David Miller wrote:
> From: Bixuan Cui <cuibixuan@...wei.com>
> Date: Mon, 20 Jul 2020 09:58:39 +0800
> 
>> Fix the warning: [-Werror=-Wframe-larger-than=]
>>
>> drivers/net/ethernet/neterion/vxge/vxge-main.c:
>> In function'VXGE_COMPLETE_VPATH_TX.isra.37':
>> drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1:
>> warning: the frame size of 1056 bytes is larger than 1024 bytes
>>
>> Dropping the NR_SKB_COMPLETED to 16 is appropriate that won't
>> have much impact on performance and functionality.
>>
>> Signed-off-by: Bixuan Cui <cuibixuan@...wei.com>
>> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
>> ---
>> v2: Dropping the NR_SKB_COMPLETED to 16.
> Applied.
thanks.