linux-kernel - Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1915e800-85b4-070b-26f3-9e5d0bac8f44@microchip.com>
Date:   Tue, 21 Jul 2020 13:42:10 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <andrew@...n.ch>
CC:     <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <Nicolas.Ferre@...rochip.com>,
        <Claudiu.Beznea@...rochip.com>, <davem@...emloft.net>,
        <kuba@...nel.org>, <f.fainelli@...il.com>, <robh+dt@...nel.org>,
        <alexandre.belloni@...tlin.com>, <Ludovic.Desroches@...rochip.com>
Subject: Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an
 MDIO node

On 21.07.2020 16:36, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp)
>>                         * decrement it before returning.
>>                         */
>>                        of_node_put(child);
>> -
>>                        return of_mdiobus_register(bp->mii_bus, np);
>>                }
> 
> Please avoid white space changes like this.

Sorry about this, it was not intended. Will fix in v2. Thanks!

> 
> Otherwise this looks O.K.
> 
>         Andrew
>