lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Jul 2020 17:19:05 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Drew Fustini <drew@...gleboard.org> Cc: Tony Lindgren <tony@...mide.com>, Linus Walleij <linus.walleij@...aro.org>, Linux OMAP Mailing List <linux-omap@...r.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Jason Kridner <jkridner@...gleboard.org>, Robert Nelson <robertcnelson@...il.com> Subject: Re: [PATCH v3] pinctrl: core: print gpio in pins debugfs file On Tue, Jul 21, 2020 at 5:17 PM Andy Shevchenko <andy.shevchenko@...il.com> wrote: > On Tue, Jul 21, 2020 at 5:10 PM Drew Fustini <drew@...gleboard.org> wrote: > > On Tue, Jul 21, 2020 at 04:02:34PM +0200, Drew Fustini wrote: > > > If there is a gpio range mapping for the pin, then print out the gpio > > > chip and line index for the pin in the debugfs 'pins' file with the > > > format: "[gpiochip-label]:line-[index] " ... > > > pin 25 (PIN25) gpio-32-63:line-25 44e10864 00000037 pinctrl-single > > > pin 26 (PIN26) gpio-32-63:line-26 44e10868 00000037 pinctrl-single > > > pin 27 (PIN27) gpio-32-63:line-27 44e1086c 00000037 pinctrl-single > > > pin 28 (PIN28) NA 44e10870 00000036 pinctrl-single > > > pin 29 (PIN29) NA 44e10874 00000006 pinctrl-single And would be also better to have 0:N/A to keep both arguments in it. > Because line is integer and label is string it is better (from parsing > of view) to put it other way around, i.e. > > %u:%s, label, line > > ... > > > Apologies - I should not have put the change log in the commit message. > > Please let me know if I should resubmit. > > Since the above comment, I guess it would be good. > Thanks for doing this! -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists