linux-kernel - Re: [PATCH for v5.9] mfd: Replace HTTP links with HTTPS ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Jul 2020 20:36:19 +0200
From:   "Alexander A. Klimov" <grandmaster@...klimov.de>
To:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh@...nel.org>
Cc:     linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, tony@...mide.com, devicetree@...r.kernel.org
Subject: Re: [PATCH for v5.9] mfd: Replace HTTP links with HTTPS ones



Am 22.07.20 um 08:54 schrieb Lee Jones:
> On Tue, 21 Jul 2020, Rob Herring wrote:
> 
>> On Sun, 19 Jul 2020 21:56:13 +0200, Alexander A. Klimov wrote:
>>> Rationale:
>>> Reduces attack surface on kernel devs opening the links for MITM
>>> as HTTPS traffic is much harder to manipulate.
>>>
>>> Deterministic algorithm:
>>> For each file:
>>>    If not .svg:
>>>      For each line:
>>>        If doesn't contain `\bxmlns\b`:
>>>          For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>>> 	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
>>>              If both the HTTP and HTTPS versions
>>>              return 200 OK and serve the same content:
>>>                Replace HTTP with HTTPS.
>>>
>>> Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>
>>> ---
>>>   Continuing my work started at 93431e0607e5.
>>>   See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@...klimov.de>' v5.7..master
>>>   (Actually letting a shell for loop submit all this stuff for me.)
> 
> I'm guessing something went wrong with your submission, as Rob's reply
> is the first time I saw this patch.  Did your bot send it to me?
Yes,
https://lore.kernel.org/lkml/20200719195613.61458-1-grandmaster@al2klimov.de/

> 
> You really should be fully reviewing anything that gets sent to the
> MLs.  "Sorry, I didn't send it, my bot did" is not an acceptable
> excuse for inadequacies.
See this as an excuse for not stopping sending on demand (if any), not 
for invalid To:.
Whoever's (not) in To: of auto-submitted patches would also (not) be 
there on manual submission because the bot just emulates myself:


➜  linux git:(master) cat submit.sh
#!/bin/bash
set -exo pipefail

if [ "$(perl scripts/get_maintainer.pl --nogit{,-fallback} --nol "$1" 
|wc -l)" -eq 0 ]; then
         GCP=--git-chief-penguins
else
         GCP=''
fi

git send-email --confirm=never "--to=$(
         perl scripts/get_maintainer.pl $GCP --norolestats "$1" |\
         perl -pe 'if (/<(.+?)>/) { $_ = "$1\n" }' |\
         tr \\n , |\
         perl -pe 's/,$//'
)" "$@"

> 
>>>   If there are any URLs to be removed completely
>>>   or at least not (just) HTTPSified:
>>>   Just clearly say so and I'll *undo my change*.
>>>   See also: https://lkml.org/lkml/2020/6/27/64
>>>
>>>   If there are any valid, but yet not changed URLs:
>>>   See: https://lkml.org/lkml/2020/6/26/837
>>>
>>>   If you apply the patch, please let me know.
>>>
>>>   Sorry again to all maintainers who complained about subject lines.
>>>   Now I realized that you want an actually perfect prefixes,
>>>   not just subsystem ones.
>>>   I tried my best...
>>>   And yes, *I could* (at least half-)automate it.
>>>   Impossible is nothing! :)
>>>
>>>
>>>   Documentation/devicetree/bindings/mfd/twl-family.txt | 2 +-
>>>   drivers/mfd/hi6421-pmic-core.c                       | 2 +-
>>>   drivers/mfd/lp873x.c                                 | 2 +-
>>>   drivers/mfd/lp87565.c                                | 2 +-
>>>   drivers/mfd/omap-usb-host.c                          | 2 +-
>>>   drivers/mfd/omap-usb-tll.c                           | 2 +-
>>>   drivers/mfd/smsc-ece1099.c                           | 2 +-
>>>   drivers/mfd/ti_am335x_tscadc.c                       | 2 +-
>>>   drivers/mfd/tps65086.c                               | 2 +-
>>>   drivers/mfd/tps65217.c                               | 2 +-
>>>   drivers/mfd/tps65218.c                               | 2 +-
>>>   drivers/mfd/tps65912-core.c                          | 2 +-
>>>   drivers/mfd/tps65912-i2c.c                           | 2 +-
>>>   drivers/mfd/tps65912-spi.c                           | 2 +-
>>>   include/linux/mfd/hi6421-pmic.h                      | 2 +-
>>>   include/linux/mfd/lp873x.h                           | 2 +-
>>>   include/linux/mfd/lp87565.h                          | 2 +-
>>>   include/linux/mfd/ti_am335x_tscadc.h                 | 2 +-
>>>   include/linux/mfd/tps65086.h                         | 2 +-
>>>   include/linux/mfd/tps65217.h                         | 2 +-
>>>   include/linux/mfd/tps65218.h                         | 2 +-
>>>   include/linux/mfd/tps65912.h                         | 2 +-
>>>   22 files changed, 22 insertions(+), 22 deletions(-)
>>>
>>
>> Acked-by: Rob Herring <robh@...nel.org>
>