linux-kernel - Re: [GIT PULL] XArray for 5.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=whW+M5kBwdNX2mLyGEDSGq=Bu7i=M5FUh+E1ZSTwsrEAw@mail.gmail.com>
Date:   Wed, 22 Jul 2020 12:01:04 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] XArray for 5.8

On Wed, Jul 22, 2020 at 11:46 AM Matthew Wilcox <willy@...radead.org> wrote:
>
> But I think the real problem is that local_lock_internal.h doesn't include
> <linux/sched.h>.  Header files shouldn't depend on other headers to be
> included first.

The big hint is that name: "internal".

Also, we often violate the "shouldn't depend on other headers" rule.
Some basic headers are just that - basic. And some headers are not.

Things like the uapi headers need to be independent, but we've had
circular ordering problems with kernel headers, and sometimes it's
just better to say "you need to just get the basic header first".

            Linus