linux-kernel - Re: [PATCH][next] PCI: imx6: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e20b7b95-4b61-4ade-cf90-40f49f3744bf@embeddedor.com>
Date:   Tue, 21 Jul 2020 22:22:52 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     Richard Zhu <hongxing.zhu@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] PCI: imx6: Use fallthrough pseudo-keyword

Hi Bjorn,

On 7/16/20 17:06, Bjorn Helgaas wrote:
> On Thu, Jul 16, 2020 at 04:10:52PM -0500, Gustavo A. R. Silva wrote:
>> Replace the existing /* fall through */ comments and its variants with
>> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
>> fall-through markings when it is the case.
>>
>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Hi Gustavo,
> 
> I'm certainly fine with these patches, and thanks for doing them!
> 
> And thanks for providing a link to the rationale.  But the URL
> contains "latest", so I think it may break if deprecated.rst or the
> section is ever renamed.
> 
> I think I would prefer if we could reference the current text, e.g.,
> via
> 
>   https://www.kernel.org/doc/html/v5.7-rc7/process/deprecated.html#implicit-switch-case-fall-through
> 

I already sent v2 with a URL to proper documentation for Linux v5.7:

https://lore.kernel.org/lkml/20200722031903.GA3711@embeddedor/

> (The v5.7 doc would be better but doesn't seem to be generated yet; I
> pinged the helpdesk about that.)
> 

Thanks for doing that. I wasn't aware that one could ask helpdesk about this.

--
Gustavo